Skip to content

Update enableLazyContextPropagation flag #30514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2024
Merged

Update enableLazyContextPropagation flag #30514

merged 1 commit into from
Jul 29, 2024

Conversation

@jackpope
Copy link
Contributor

@jackpope jackpope commented Jul 29, 2024

  • Flag set to true for FB
  • Flag set to experimental for OSS

@vercel
Copy link

vercel bot commented Jul 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 8:44pm

@jackpope jackpope requested a review from kassens July 29, 2024 20:40
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Jul 29, 2024
@react-sizebot
Copy link

react-sizebot commented Jul 29, 2024

Comparing: a451de0...b4899e8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.46 kB 501.46 kB = 89.98 kB 89.98 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js +0.46% 506.28 kB 508.59 kB +0.53% 90.68 kB 91.15 kB
facebook-www/ReactDOM-prod.classic.js = 601.27 kB 596.53 kB = 106.28 kB 105.80 kB
facebook-www/ReactDOM-prod.modern.js = 577.38 kB 572.82 kB = 102.52 kB 102.01 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-art/cjs/react-art.production.js +0.77% 299.04 kB 301.33 kB +0.86% 51.73 kB 52.18 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.js +0.73% 301.83 kB 304.05 kB +0.79% 53.68 kB 54.10 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.js +0.67% 382.67 kB 385.24 kB +0.78% 62.87 kB 63.36 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.js +0.63% 411.07 kB 413.65 kB +0.77% 66.95 kB 67.47 kB
oss-experimental/react-art/cjs/react-art.development.js +0.49% 564.29 kB 567.04 kB +0.47% 91.45 kB 91.88 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js +0.48% 544.05 kB 546.64 kB +0.46% 89.20 kB 89.61 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js +0.46% 506.28 kB 508.59 kB +0.53% 90.68 kB 91.15 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.js +0.44% 521.03 kB 523.34 kB +0.51% 94.35 kB 94.82 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js +0.44% 641.93 kB 644.76 kB +0.47% 103.23 kB 103.71 kB
facebook-www/ReactTestRenderer-dev.modern.js +0.44% 567.78 kB 570.28 kB +0.40% 93.34 kB 93.71 kB
facebook-www/ReactTestRenderer-dev.classic.js +0.44% 567.79 kB 570.29 kB +0.40% 93.34 kB 93.71 kB
oss-experimental/react-dom/cjs/react-dom-profiling.profiling.js +0.43% 539.16 kB 541.48 kB +0.54% 95.88 kB 96.40 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js +0.29% 947.21 kB 949.97 kB +0.35% 160.12 kB 160.67 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js +0.29% 963.65 kB 966.41 kB +0.34% 162.96 kB 163.51 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js +0.29% 964.18 kB 966.93 kB +0.33% 163.98 kB 164.52 kB
facebook-www/React-dev.classic.js = 74.39 kB 74.22 kB = 16.27 kB 16.23 kB
facebook-www/React-dev.modern.js = 73.53 kB 73.36 kB = 16.13 kB 16.09 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,069.13 kB 1,063.78 kB = 180.36 kB 179.79 kB
facebook-www/ReactDOM-dev.modern.js = 1,052.22 kB 1,046.87 kB = 176.45 kB 175.91 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,106.31 kB 1,100.68 kB = 186.95 kB 185.88 kB
facebook-www/ReactDOM-dev.classic.js = 1,089.40 kB 1,083.77 kB = 183.00 kB 181.91 kB
facebook-www/React-profiling.classic.js = 22.92 kB 22.76 kB = 5.94 kB 5.90 kB
facebook-www/React-profiling.modern.js = 22.92 kB 22.76 kB = 5.94 kB 5.90 kB
facebook-www/React-prod.classic.js = 22.48 kB 22.33 kB = 5.86 kB 5.82 kB
facebook-www/React-prod.modern.js = 22.48 kB 22.32 kB = 5.85 kB 5.82 kB
facebook-www/ReactReconciler-dev.classic.js = 741.72 kB 736.25 kB = 118.39 kB 117.83 kB
facebook-www/ReactReconciler-dev.modern.js = 716.85 kB 711.49 kB = 114.27 kB 113.70 kB
facebook-www/ReactDOM-profiling.classic.js = 631.23 kB 626.49 kB = 110.73 kB 110.27 kB
facebook-www/ReactDOM-profiling.modern.js = 606.70 kB 602.14 kB = 106.76 kB 106.28 kB
facebook-www/ReactDOMTesting-prod.modern.js = 592.12 kB 587.57 kB = 106.23 kB 105.72 kB
facebook-www/ReactDOMTesting-prod.classic.js = 616.01 kB 611.27 kB = 109.98 kB 109.49 kB
facebook-www/ReactDOM-prod.classic.js = 601.27 kB 596.53 kB = 106.28 kB 105.80 kB
facebook-www/ReactDOM-prod.modern.js = 577.38 kB 572.82 kB = 102.52 kB 102.01 kB
facebook-www/ReactART-dev.classic.js = 659.17 kB 653.69 kB = 105.76 kB 105.20 kB
facebook-www/ReactART-dev.modern.js = 635.68 kB 630.33 kB = 102.06 kB 101.50 kB
facebook-www/ReactReconciler-prod.classic.js = 461.89 kB 456.85 kB = 74.68 kB 74.18 kB
facebook-www/ReactReconciler-prod.modern.js = 442.99 kB 438.09 kB = 71.87 kB 71.42 kB
facebook-www/ReactART-prod.classic.js = 370.65 kB 365.88 kB = 62.82 kB 62.34 kB
facebook-www/ReactART-prod.modern.js = 353.18 kB 348.59 kB = 60.09 kB 59.59 kB

Generated by 🚫 dangerJS against 1a19ccc

@jackpope jackpope merged commit 397646a into facebook:main Jul 29, 2024
@jackpope jackpope deleted the enable-lazy-context-propagation-flag branch July 29, 2024 20:50
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
@jackpope
Update enableLazyContextPropagation flag (#30514)
5c9e62f 
- Flag set to true for FB
- Flag set to experimental for OSS

DiffTrain build for [397646a](397646a)
@eps1lon eps1lon mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kassens kassens kassens approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jackpope @react-sizebot @kassens @facebook-github-bot